Skip to content
This repository was archived by the owner on Aug 27, 2025. It is now read-only.

Conversation

bzawisto
Copy link
Contributor

@bzawisto bzawisto commented Dec 5, 2023

Description

Since both adding to bulkQueue and doing actual write to mongodb use the same mutex - this PR delegates operations made on mongo to be performed on other thread, different than the one running ProcessFinalBlock.
Also, some no longer verbose logging statements have been removed.

Backward Compatibility

  • This is not a breaking change
  • This is a breaking change

Review Suggestion

Status

Implementation

  • ready for review

Integration Test (Core Team)

  • local machine test
  • small-scale cloud test

chetan-zilliqa and others added 30 commits October 26, 2023 17:35
#3823) (#3840)

Co-authored-by: Richard Watts <108257153+rrw-zilliqa@users.noreply.github.com>
* (feat) ZIL-5423: Deployment instructions for reward control contracts. (#3823)

* Tweak constants for blocktime and txn distribution (#3839)

* Fixing double enter into consensus in case gossip arrives early (#3842)

Co-authored-by: bzawisto <bartosz@zilliqa.com>

* Update release version to v9.3.0rc0

* Update release version to v9.3.0rc1 (#3841)

---------

Co-authored-by: Richard Watts <108257153+rrw-zilliqa@users.noreply.github.com>
Co-authored-by: Bartosz Zawistowski <39065214+bzawisto@users.noreply.github.com>
Co-authored-by: bzawisto <bartosz@zilliqa.com>
* Make the bucket name in localdev.py configurable.
* Update download & upload scripts to use a CDN.
* (feat) ZIL-5423: Deployment instructions for reward control contracts. (#3823)

* Tweak constants for blocktime and txn distribution (#3839)

* Fixing double enter into consensus in case gossip arrives early (#3842)

Co-authored-by: bzawisto <bartosz@zilliqa.com>

* [master] Zil 5450 network native tests improve (#3845)

* chore: update response stats for debugging

* Add logs when txn forwarding happens

* Fix for mismatch in txn pool data

* Some helpful addons

* Fixing cosig retrieval

* Fixes

* Remove unnecessary logging

* Adding more logging

* More logs

* Followup investigation

* Another one

* Hard revert

* Close socket

* Save the changes that have been tested and verified

* Save the changes that have been tested and verified

* Save the changes that have been tested and verified

* Save the changes that have been tested and verified

* Save the changes that have been tested and verified

* Save the changes that have been tested and verified

* updates and experiment
Renamed branch to help ci

* updates and experiment
Renamed branch to help ci

---------

Co-authored-by: Chetan Phirke <chetan@zilliqa.com>
Co-authored-by: bzawisto <bartosz@zilliqa.com>

* [master] ZIL-5406: add support for a cdn (#3848)

* Make the bucket name in localdev.py configurable.
* Update download & upload scripts to use a CDN.

* Fixes to the scripts and startups - does not touch cpp files. (#3849)

* Fix CI issue regarding installing nodejs (#3852)

* feat: update Zilliqa SW version

* Adding more helpful logs and remove unneeded peer check (#3846)

Co-authored-by: bzawisto <bartosz@zilliqa.com>

---------

Co-authored-by: Richard Watts <108257153+rrw-zilliqa@users.noreply.github.com>
Co-authored-by: chetan-zilliqa <66236813+chetan-zilliqa@users.noreply.github.com>
Co-authored-by: Bartosz Zawistowski <39065214+bzawisto@users.noreply.github.com>
Co-authored-by: bzawisto <bartosz@zilliqa.com>
Co-authored-by: Stephen White <93026204+Steve-White-UK@users.noreply.github.com>
Co-authored-by: Chetan Phirke <chetan@zilliqa.com>
Co-authored-by: Yaron <yaron@zilliqa.com>
Co-authored-by: Saeed Dadkhah <saeed@zilliqa.com>
* [master] Support legacy transactions without replay protection. (#3847)

* Increase initial funds of signers (#3860)

* Support creating signers using a zil-based account in setup script (#3861)

* Support creating signers using a zil-based account in setup script

* Move SignerHelpers to helpers folder

* Fix some compilation error

* Add refund signers task

* Update setup task

* update config

* (fix) ZIL-5457: Don't segfault when asked for a block after the end of the chain (plus some additional protection for illformed internal calls). (#3856)

* DEVOPS-1093: Pass along otterscan options so that zblockchain can tell localdev what to ask testnet to do. (#3863)

* [master] Make setup script more user-friendly.  (#3862)

* [master] Proper check for receiving announce msg early (#3864)

* Proper check for receiving announce msg early

* Proper check for receiving announce msg early (2)

---------

Co-authored-by: bzawisto <bartosz@zilliqa.com>

* Update release version to v9.3.0rc6

---------

Co-authored-by: Saeed Dadkhah <saeed@zilliqa.com>
Co-authored-by: Richard Watts <108257153+rrw-zilliqa@users.noreply.github.com>
Co-authored-by: Bartosz Zawistowski <39065214+bzawisto@users.noreply.github.com>
Co-authored-by: bzawisto <bartosz@zilliqa.com>
* [master] Support legacy transactions without replay protection. (#3847)

* Increase initial funds of signers (#3860)

* Support creating signers using a zil-based account in setup script (#3861)

* Support creating signers using a zil-based account in setup script

* Move SignerHelpers to helpers folder

* Fix some compilation error

* Add refund signers task

* Update setup task

* update config

* (fix) ZIL-5457: Don't segfault when asked for a block after the end of the chain (plus some additional protection for illformed internal calls). (#3856)

* DEVOPS-1093: Pass along otterscan options so that zblockchain can tell localdev what to ask testnet to do. (#3863)

* [master] Make setup script more user-friendly.  (#3862)

* [master] Proper check for receiving announce msg early (#3864)

* Proper check for receiving announce msg early

* Proper check for receiving announce msg early (2)

---------

Co-authored-by: bzawisto <bartosz@zilliqa.com>

* [master] Change balances task so that it gets balances in parallel. (#3866)

* Change blaances task so that it gets balances in parallel

* run lint

* Return 0x0 if the signature passed to eth_sendRawTransaction is invalid. (#3867)

* [master] Zil 5473 localdev changes gossip (#3869)

* Enhance the configuration to allow localdev to operate with gossip mode
start the full set of dameons including prometheus and not hang waiting for ip addresses to be assigned
disable tracing until it has been fully tested.
Enable prometheus only in this version.

* Enhance the configuration to allow localdev to operate with gossip mode
start the full set of dameons including prometheus and not hang waiting for ip addresses to be assigned
disable tracing until it has been fully tested.
Enable prometheus only in this version.
Move change of commit_window to localdev and not the constants.xml

* Shuffle signers to use them evenly in tests. (#3868)

* [master] ZIL-5447: Implement header hash customisation for remote miners (#3857)

* ZIL-5447: Implement header hash customisation for remote miners

* ZIL-5447: Fix out-of-bounds iterator access

---------

Co-authored-by: Saeed Dadkhah <saeed@zilliqa.com>
Co-authored-by: Richard Watts <108257153+rrw-zilliqa@users.noreply.github.com>
Co-authored-by: Bartosz Zawistowski <39065214+bzawisto@users.noreply.github.com>
Co-authored-by: bzawisto <bartosz@zilliqa.com>
Co-authored-by: Stephen White <93026204+Steve-White-UK@users.noreply.github.com>
Co-authored-by: James Hinshelwood <JamesHinshelwood@users.noreply.github.com>
* Exclude complete persistence from cdn cache
@github-actions github-actions bot changed the title Let mongo ops run on a separate thread [master] Let mongo ops run on a separate thread Dec 5, 2023
@bzawisto bzawisto changed the title [master] Let mongo ops run on a separate thread ZIL-5507 Let mongo ops run on a separate thread Dec 5, 2023
@bzawisto bzawisto changed the title ZIL-5507 Let mongo ops run on a separate thread [master] ZIL-5507 Let mongo ops run on a separate thread Dec 5, 2023
@bzawisto bzawisto enabled auto-merge (squash) December 5, 2023 15:46
@bzawisto bzawisto merged commit 99e8f80 into master Dec 6, 2023
@bzawisto bzawisto deleted the temp_branch branch December 6, 2023 07:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

Status: PRs done (merged)

Development

Successfully merging this pull request may close these issues.

4 participants