Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImplicitUsings #392

Merged
merged 5 commits into from
Feb 19, 2025
Merged

ImplicitUsings #392

merged 5 commits into from
Feb 19, 2025

Conversation

SimonCropp
Copy link
Contributor

No description provided.

@SimonCropp
Copy link
Contributor Author

need any help with the broken CI?

Copy link
Collaborator

@jodydonetti jodydonetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jodydonetti jodydonetti merged commit df5d7b3 into ZiggyCreatures:main Feb 19, 2025
1 check failed
@jodydonetti
Copy link
Collaborator

need any help with the broken CI?

That would be great, thanks! Already have an idea of what happened that break it?
I haven't had time yet to take a look, and locally they work fine.

PS: if the thing is some tests that fails because of timing issues, I'm already working on making them a little more resilient to timing differencies between the local and CI env, so don't bother waisting your time on that.

@SimonCropp SimonCropp deleted the ImplicitUsings branch February 19, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants