Better HAL for STM32F303 #729
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…est regz register.
tact1m4n3
reviewed
Nov 24, 2025
Collaborator
tact1m4n3
left a comment
tact1m4n3
left a comment
There was a problem hiding this comment.
Thanks! It's nice to see more hals getting attention 😄
| .UART5 => UART5, | ||
| }; | ||
| return struct { | ||
| pub const Writer = std.io.GenericWriter(*const Self, error{}, writer_fn); |
Collaborator
There was a problem hiding this comment.
GenericWriter is deprecated. Can you use the new std.Io.Writer instead?
| /// A UART configuration. The config defaults to the *8N1* setting, so "8 data bits, no parity, 1 stop bit" which is the | ||
| /// most common serial format. | ||
| /// A UART configuration. | ||
| pub const Config = struct { |
Collaborator
There was a problem hiding this comment.
Why did you change this? Anyways everything in the experimental directory is not used at the moment
| pins.PIN15, | ||
| }; | ||
|
|
||
| microzig.board.debug_write("test"); |
Collaborator
There was a problem hiding this comment.
Can you remove this function please? Seems like it's broken anyways? 😆 Instead go for std.log and the uart logger if you need logging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rewrite of the hal for STM32F303.
It improve the compatibility with other HAL.
It also provide fixes for the latest regz generated peripherals.
For now only blinky would work and Usart kind of work with only USART1.
I would like to support better Alternate function and the RCC peripherals before moving on.