Activate CI/CD testing of windows

This patch changes all github action jobs to also test the library in Windows (and build the corresponding wheels).
ZhouShengbao · May 23, 2020 · 1194b33 · 1194b33
1 parent 8d870fe
commit 1194b33
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 23 deletions.
diff --git a/.github/workflows/build_wheels.yml b/.github/workflows/build_wheels.yml
@@ -17,15 +17,13 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        # windows-latest is currently excluded, because
-        # (a) In 2.7 shapely causes an install error
-        # (b) numpy seems to not know float128 in windows, but that datatype
-        #     is required for many test cases. Not having it will cause the
-        #     test to error, even if the tested function is correct.
-        os: [ubuntu-latest, macos-latest]
+        os: [ubuntu-latest, macos-latest, windows-latest]
         # see supported versions at
         # https://raw.githubusercontent.com/actions/python-versions/master/versions-manifest.json
-        python-version: [2.7, 3.8]
+        python-version: [2.7, 3.5, 3.6, 3.7, 3.8]
+        exclude:
+          - os: windows-latest
+            python-version: 2.7  # causes a Shapely install error
     env:
       OS: ${{ matrix.os }}
       PYTHON: ${{ matrix.python-version }}

diff --git a/.github/workflows/test_master.yml b/.github/workflows/test_master.yml
@@ -20,15 +20,13 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        # windows-latest is currently excluded, because
-        # (a) In 2.7 shapely causes an install error
-        # (b) numpy seems to not know float128 in windows, but that datatype
-        #     is required for many test cases. Not having it will cause the
-        #     test to error, even if the tested function is correct.
-        os: [ubuntu-latest, macos-latest]
+        os: [ubuntu-latest, macos-latest, windows-latest]
         # see supported versions at
         # https://raw.githubusercontent.com/actions/python-versions/master/versions-manifest.json
         python-version: [2.7, 3.5, 3.6, 3.7, 3.8]
+        exclude:
+          - os: windows-latest
+            python-version: 2.7  # causes a Shapely install error
     env:
       OS: ${{ matrix.os }}
       PYTHON: ${{ matrix.python-version }}

diff --git a/.github/workflows/test_pull_requests.yml b/.github/workflows/test_pull_requests.yml
@@ -18,23 +18,27 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        # windows-latest is currently excluded, because
-        # (a) In 2.7 shapely causes an install error
-        # (b) numpy seems to not know float128 in windows, but that datatype
-        #     is required for many test cases. Not having it will cause the
-        #     test to error, even if the tested function is correct.
-        os: [ubuntu-latest, macos-latest]
+        os: [ubuntu-latest, macos-latest, windows-latest]
         # see supported versions at
         # https://raw.githubusercontent.com/actions/python-versions/master/versions-manifest.json
         python-version: [2.7, 3.5, 3.6, 3.7, 3.8]
         # test only 2.7 and the latest 3.x on mac
+        # test only the latest 3.x on windows
         exclude:
           - os: macos-latest
             python-version: 3.5
           - os: macos-latest
             python-version: 3.6
           - os: macos-latest
             python-version: 3.7
+          - os: windows-latest
+            python-version: 2.7  # causes a Shapely install error
+          - os: windows-latest
+            python-version: 3.5
+          - os: windows-latest
+            python-version: 3.6
+          - os: windows-latest
+            python-version: 3.7
     env:
       OS: ${{ matrix.os }}
       PYTHON: ${{ matrix.python-version }}

diff --git a/changelogs/master/improved/20200521_improved_cicd_testing.md b/changelogs/master/improved/20200521_improved_cicd_testing.md
@@ -1,11 +1,12 @@
-# Improved CI/CD Testing #670
+# Improved CI/CD Testing #670 #678
 
 This patch improves the CI/CD environment by adding
 github actions. The library is now automatically tested
 in Ubuntu with python 2.7, 3.5, 3.6, 3.7 and 3.8,
-as well as MacOS with the same python versions.
-(Previously, only Ubuntu with python <=3.7 was
-automatically tested in the CI/CD chain).
+as well as MacOS and Windows with the same python
+versions (except for 2.7 in Windows).
+Previously, only Ubuntu with python <=3.7 was
+automatically tested in the CI/CD chain.
 
 Additionally, the CI/CD pipeline now also generates
 wheel files (sdist, bdist) for every patch merged