Repository navigation
Refuel pads: remove the repair energy demand when repair is aborted - #5898
Open
moss-orbit-9f339e wants to merge 2 commits into
Open
moss-orbit-9f339e wants to merge 2 commits into
moss-orbit-9f339e wants to merge 2 commits into
Conversation
Abort cleanup referenced miscPriorityKey outside its local scope, leaving the aircraft's repair demand registered. The fix uses "p" .. unitID to match the registration key. Lua 5.1 syntax validation and git diff --check passed. Co-authored-by: GPT-6.1 Sol <noreply@openai.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
I want to instead add |
Use GetMiscPriorityKey(unitID) in ForceImmediateAbort and in the landing loop, so the key format is defined in one place (review feedback). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ForceImmediateAbortcallsGG.StopMiscPriorityResourcing(padID, miscPriorityKey), butmiscPriorityKeyis a local of another function, so it is nil there and the pad's repair energy demand is never removed. This change uses the same key,"p" .. unitID.Testing (Windows, RTX 3080, master ee8950e), test gadget repairs an aircraft on a pad and aborts:
AI disclosure: OpenAI Codex (GPT-6.1 Sol) found and fixed these bugs and wrote the test gadgets; Claude Code checked each finding and reviewed every change. I reviewed the changes.