Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev #435

Merged
merged 228 commits into from
May 18, 2023
Merged

Dev #435

merged 228 commits into from
May 18, 2023

Conversation

Zer0-bit
Copy link
Owner

@Zer0-bit Zer0-bit commented Apr 10, 2023 •
edited
Loading

NEW:

image
image

@Zer0-bit Zer0-bit requested a review from kstam as a code owner April 10, 2023 09:34
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

matiasjrossi and others added 28 commits May 18, 2023 14:25
@matiasjrossi
store nextion page IDs as enum + shorter enum names
2bf9f3c
@matiasjrossi
simplify string and remove magic number
f518669
@matiasjrossi
clean up snprintfs and rekt retry loop
0f85cc5
@matiasjrossi
streamline lcd profiles interface
d09491a 
- reuse fetch per page
- push that logic down to nextion impl
- remove visibility on individual functions
@matiasjrossi
extract eeprom write error handling
6e866e7
@matiasjrossi
remove unnecessary eeprom write
3598e2c
@matiasjrossi
remove boilerplate
32429ff
@matiasjrossi
ffs: load them profiles
73bff8e
@matiasjrossi
fix save profile as default
5fbebe4
@matiasjrossi
Revert "fix save profile as default"
f96e701 
This reverts commit 5fbebe4.
@matiasjrossi
simpler fix for save profile as default
9180da7
@matiasjrossi
update profiler on profile switch
f3189dc
just tidy up and generating the tfts
d6fbd95
@matiasjrossi
ofc unsigned cannot be <0
22377cb
generated new tfts
f37c474
fix profile id saving
96d3e17
fix the profile trigger race condition
1a41a14
@Zer0-bit
Shitxtion split comms with refactor (#449)
83aca66
whitespace
27c3b23
yolo
9025085
some clang shit
b61d9dd
tests
eb50afa
not pointer
0974967
ffs
754d5a4
back to pointer
e4615cb
init shotsnapshot instance
4364ea2
ffs
cc6b060
@Zer0-bit
Feature/shitxtion reloaded (#445)
e64e03d
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 152 Code Smells

0.0% 0.0% Coverage
37.3% 37.3% Duplication

@Zer0-bit Zer0-bit merged commit 778e7ce into release/stm32-blackpill May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kstam kstam Awaiting requested review from kstam kstam is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Zer0-bit @matiasjrossi @judahrand @banoz @kstam