Issue676 #1

Zeglow · 2025-09-22T04:25:04Z

Homework 2 Pull Request

Checklist before creating

There are no Checkstyle issues.
There are no SpotBugs issues.
There are no javadoc errors.
All tests in the file pass.

Questions

Will you get full credit on this assignment?

Yes, I expect to receive full credit. I successfully converted 15 test methods with multiple assertions to use @ParameterizedTest, following JUnit 5 best practices.

How long did you spend on the assignment?

Approximately 6 hours total, including:

Initial setup: It took so long because there was something wrong with jbang when I run build jabref, I tried multiple methods but didn't fix it. Then it recovered itself... Maybe it was caused by network issues. (2 hours)
Converting the 15 test methods (2.5 hours)
Testing (0.5 hour)
Commit&PR (0.5 hour)

What problems did you encounter, and how did you deal with them?

JBang had problems during the initial build jabref step. After trying multiple solutions, it resolved itself, likely due to network connectivity issues. This delayed the initial setup by about 2 hours.

Initially I ran tests in the wrong module (jabgui instead of jablib). Solved by identifying the correct file location.

What help did you give or receive on this assignment (including answering these question)? What was your AI usage?

I collaborated with a classmate on task division - she handled the first 11 methods and the other class in AB while I converted the remaining 15. We coordinated to avoid duplicate work.
I used AI assistance (Claude) for:

Learning proper @ParameterizedTest syntax and best practices
Code review suggestions
Git commands suggestions
Debugging gradle test execution issues

Summary of Changes

Methods converted: nAuthors1, applyModifiers, checkLegalKeyNoUnwantedCharacters, checkLegalKeyUnwantedCharacters, keywordsNKeywordsSeparatedBySpace, keywordNKeywordsSeparatedBySpace, title, camel, shortTitle, veryShortTitle, lastPage, pagePrefix, firstPage, nAuthors3, oneAuthorPlusIni

- Converted nAuthors3() test method to use @ParameterizedTest with @MethodSource Addresses JabRef#676

…t method to use @ParameterizedTest with @MethodSource Addresses JabRef#676

jablib/src/test/java/org/jabref/logic/citationkeypattern/CitationKeyGeneratorTest.java

espertusnu · 2025-10-07T02:58:25Z

What is the status of this PR?

Zeglow · 2025-10-07T04:27:01Z

What is the status of this PR?

I just resolved the submodule conflicts (csl-locales and csl-styles). It seems that this PR has no conflicts with the base branch now.

espertusnu

Please look for additional opportunities to parameterize tests. Let me know if you have any questions.

jablib/src/test/java/org/jabref/logic/citationkeypattern/CitationKeyGeneratorTest.java

espertusnu · 2025-10-07T16:20:23Z

jablib/src/test/java/org/jabref/logic/citationkeypattern/CitationKeyGeneratorTest.java

    }

    @Test
    void authIniNEmptyReturnsEmpty() {


This can be combined with the previous method.

espertusnu · 2025-10-07T16:21:06Z

jablib/src/test/java/org/jabref/logic/citationkeypattern/CitationKeyGeneratorTest.java

Why not parameterize these?

espertusnu · 2025-10-07T17:49:06Z

[like] Spertus, Ellen reacted to your message:

________________________________ From: Avery ***@***.***> Sent: Tuesday, October 7, 2025 5:16:11 PM To: Zeglow/jabref ***@***.***> Cc: Spertus, Ellen ***@***.***>; Comment ***@***.***> Subject: Re: [Zeglow/jabref] Issue676 (PR #1) @Zeglow commented on this pull request.

________________________________ In jablib/src/test/java/org/jabref/logic/citationkeypattern/CitationKeyGeneratorTest.java<#1 (comment)>:

Lucia and I both worked on the [CitationKeyGeneratorTest.java] to complete all the methods. I'll update my version with her changes as soon as possible. — Reply to this email directly, view it on GitHub<#1 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A44JAIZRQIF7EGHXW5IY4D33WPYNXAVCNFSM6AAAAACHD6ES5KVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTGMJRGA4TANBUHE>. You are receiving this because you commented.Message ID: ***@***.***>

espertusnu · 2025-10-07T17:50:09Z

Lucia and I both worked on the [CitationKeyGeneratorTest.java] to complete all the methods. I'll update my version with her changes as soon as possible.

I hadn't remembered that multiple people were working on that file. Just let me know what lines are your responsibility, and I'll review only those.

espertusnu · 2025-10-07T17:50:35Z

It did seem unlike you not to do a thorough job!

Zeglow · 2025-10-07T17:53:39Z

Lucia and I both worked on the [CitationKeyGeneratorTest.java] to complete all the methods. I'll update my version with her changes as soon as possible.

I hadn't remembered that multiple people were working on that file. Just let me know what lines are your responsibility, and I'll review only those.

Thank you! I worked on the methods starting from line 579 -> oneAuthorPlusIni.

jablib/src/test/java/org/jabref/logic/citationkeypattern/CitationKeyGeneratorTest.java

…uthors1() parameterized test

Zeglow · 2025-10-15T00:32:30Z

Hi Ellen,
I've addressed all the review comments. So sorry for the late response! I was unwell with an ear infection these days and wasn't feeling well enough to work...Thanks for your patience!
P.S. Do I need to merge my changes with Lucia's modifications before submitting a PR to the main JabRef repository?
Thanks,
Avery

espertusnu · 2025-10-15T00:54:02Z

I'm sorry you were unwell and I hope you are all better.

While it would be easier for the jabref people if you merge your changes, one of you wouldn't be listed as a contributor.

Something you could if Lucia agreed would be to split on file boundaries, where you submit the 2 files you did alone, and she submits the file you both worked on, mentioning you in the PR. @Zeglow

Zeglow · 2025-10-15T02:48:35Z

I'm sorry you were unwell and I hope you are all better.

While it would be easier for the jabref people if you merge your changes, one of you wouldn't be listed as a contributor.

Something you could if Lucia agreed would be to split on file boundaries, where you submit the 2 files you did alone, and she submits the file you both worked on, mentioning you in the PR. @Zeglow

Hi Ellen,

Thank you for your understanding!

I discussed this with Lucia. Actually, I don't have any files that I worked on independently - we only collaborated on CitationKeyGeneratorTest.java together. So we've decided that I will submit the PR for CitationKeyGeneratorTest.java and mention her contributions in the PR description. And she will submit the file she worked on independently. This way we'll both be listed as contributors.

espertusnu

I see that I failed to share these comments. Don't bother correcting them in this PR, but do correct them.

espertusnu · 2025-10-15T00:50:58Z

jablib/src/test/java/org/jabref/logic/citationkeypattern/CitationKeyGeneratorTest.java

+                Arguments.of("Green Scheduling of `Whatever`", "GreenSchedulingofWhatever")
+        );
    }



This could be CSV.

espertusnu · 2025-10-15T00:51:20Z

jablib/src/test/java/org/jabref/logic/citationkeypattern/CitationKeyGeneratorTest.java

    }

    @Test
    void generateKeyCorrectKeyWithAndOthersAtTheEnd() {


jablib/src/test/java/org/jabref/logic/citationkeypattern/CitationKeyGeneratorTest.java

Zeglow added 14 commits September 21, 2025 00:07

Convert nAuthors3() to @ParameterizedTest

543aeb4

- Converted nAuthors3() test method to use @ParameterizedTest with @MethodSource Addresses JabRef#676

Convert firstPage() to @ParameterizedTest - Converted firstPage() tes…

7093db5

…t method to use @ParameterizedTest with @MethodSource Addresses JabRef#676

Convert pagePrefix() to @ParameterizedTest

9328dbd

Convert lastPage() to @ParameterizedTest

4910746

convert veryShortTitle to @ParameterizedTest

35d5972

convert shortTitle to @ParameterizedTest

985e32d

Convert title() to @ParameterizedTest

f9b0cb8

Convert keywordNKeywordsSeparatedBySpace() to @ParameterizedTest

d5e91d7

Convert keywordsNKeywordsSeparatedBySpace() to @ParameterizedTest

3f2ebb3

Convert checkLegalKeyUnwantedCharacters() to @ParameterizedTest

b654748

Convert applyModifiers() to @ParameterizedTest

f9abf53

Convert checkLegalKeyNoUnwantedCharacters() to @ParameterizedTest

44c1142

Convert oneAuthorPlusIni() to @ParameterizedTest

f1dcb5d

Convert nAuthors1() to @ParameterizedTest

73fbf7d

espertusnu reviewed Sep 30, 2025

View reviewed changes

jablib/src/test/java/org/jabref/logic/citationkeypattern/CitationKeyGeneratorTest.java Show resolved Hide resolved

jablib/src/test/java/org/jabref/logic/citationkeypattern/CitationKeyGeneratorTest.java Show resolved Hide resolved

Merge main branch and resolve submodule conflicts

77aca24

espertusnu requested changes Oct 7, 2025

View reviewed changes

Zeglow added 2 commits October 14, 2025 17:17

Address review comments: combine tests and remove duplicate assertions

708c544

Address review comments: Combined nAuthors1EmptyReturnEmpty() into nA…

1de403b

…uthors1() parameterized test

Refactor: Convert CitationKeyGeneratorTest methods to parameterized test

3fb2f42

espertusnu reviewed Oct 18, 2025

View reviewed changes

Issue676 #1

Are you sure you want to change the base?

Issue676 #1

Uh oh!

Conversation

Zeglow commented Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Homework 2 Pull Request

Checklist before creating

Questions

Will you get full credit on this assignment?

How long did you spend on the assignment?

What problems did you encounter, and how did you deal with them?

What help did you give or receive on this assignment (including answering these question)? What was your AI usage?

Summary of Changes

Uh oh!

Uh oh!

Uh oh!

espertusnu commented Oct 7, 2025

Uh oh!

Zeglow commented Oct 7, 2025

Uh oh!

espertusnu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

espertusnu Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

espertusnu Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

espertusnu commented Oct 7, 2025 via email

Uh oh!

espertusnu commented Oct 7, 2025

Uh oh!

espertusnu commented Oct 7, 2025

Uh oh!

Zeglow commented Oct 7, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Zeglow commented Oct 15, 2025

Uh oh!

espertusnu commented Oct 15, 2025

Uh oh!

Zeglow commented Oct 15, 2025

Uh oh!

espertusnu left a comment

Choose a reason for hiding this comment

Uh oh!

espertusnu Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

espertusnu Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Zeglow commented Sep 22, 2025 •

edited

Loading