Skip to content

Commit

Permalink
add patch for 1.8.1 compatibility.
Browse files Browse the repository at this point in the history
1.8.1 couchbase does not have the CouchAPIBase node attribute, therefore len(capiEpList) will always be zero.
This results in IsValid() returning false when config.bktType == BktTypeCouchbase. Instead, we should not
check the length of capiEpList as part of the validation of the routeconfig.

Change-Id: I4b0f5e0b0c43634b201f533524f54bc1c1c76794
Reviewed-on: http://review.couchbase.org/65060
Reviewed-by: Brett Lawson <brett19@gmail.com>
Tested-by: Brett Lawson <brett19@gmail.com>
  • Loading branch information
deanxorr authored and brett19 committed Jun 20, 2016
1 parent af0565d commit a17d7ea
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion gocbcore/routeconfig.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ func (config *routeConfig) IsValid() bool {
}
switch config.bktType {
case BktTypeCouchbase:
return len(config.vbMap) > 0 && len(config.vbMap[0]) > 0 && len(config.capiEpList) > 0
return len(config.vbMap) > 0 && len(config.vbMap[0]) > 0
case BktTypeMemcached:
return len(config.ketamaMap) > 0
default:
Expand Down

0 comments on commit a17d7ea

Please sign in to comment.