Skip to content

fix(UX-1563): High Contrast Issue #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aygurs wants to merge 2 commits into from
Closed

fix(UX-1563): High Contrast Issue #424

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ae1e1b
fix(UX-1563): High Contrast Issue - Not global fix
aygurs Feb 2, 2026
a9471d9
Merge branch 'main' into UX-1563
aygurs Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/zeta_flutter/lib/src/components/buttons/button.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,13 @@ class ZetaButton extends ZetaStatelessWidget {
Widget build(BuildContext context) {
final minConstraints = _minConstraints(context);
final iconSize = _iconSize(context);
final zeta = Zeta.of(context);

// Override to sharp if in AAA contrast mode
final contrastBorderType = zeta.contrast == ZetaContrast.aaa
? ZetaWidgetBorder.sharp
: borderType ?? (context.rounded ? ZetaWidgetBorder.rounded : ZetaWidgetBorder.sharp);
Comment on lines +197 to +199
Copy link

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This AAA contrast mode functionality lacks test coverage. The existing accessibility tests in button_test.dart iterate through contrast modes (aa and aaa) but don't specifically verify that sharp borders are enforced in AAA mode. Consider adding a test that verifies the border behavior in AAA contrast mode, especially when borderType is explicitly set to a different value.

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

@aygurs aygurs Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair - will be done if solution is kept


return Semantics(
button: true,
enabled: onPressed != null,
Expand All @@ -203,7 +210,7 @@ class ZetaButton extends ZetaStatelessWidget {
onPressed: onPressed,
style: buttonStyle(
context,
borderType ?? (context.rounded ? ZetaWidgetBorder.rounded : ZetaWidgetBorder.sharp),
contrastBorderType,
type,
),
child: SelectionContainer.disabled(
Expand Down