-
Notifications
You must be signed in to change notification settings - Fork 5
feat(UX-1461): Voice Memo component #377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
PR Checks complete
Created with Flutter code quality action |
Visit the preview URL for this PR (updated for commit 121d1fe): https://zeta-flutter-main--pr-377-ux-1461-4dk6mo27.web.app (expires Thu, 28 Aug 2025 18:35:07 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 5ca681de0a0ad9185b252304c113355d5ee04ca6 |
656f603
to
4cded56
Compare
fix: widgetbook for voice memo TODO: Fix url for web
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2875bd3
to
f58ba58
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new Voice Memo component to the Zeta Flutter design system. The implementation includes both a recording component (ZetaVoiceMemo
) and an audio visualizer component (ZetaAudioVisualizer
) with comprehensive audio waveform visualization capabilities.
- Adds complete voice recording and playback functionality with audio visualizations
- Implements WAV audio processing for waveform generation
- Updates progress components with animation duration support and center widget capability
Reviewed Changes
Copilot reviewed 54 out of 62 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
packages/zeta_flutter/lib/src/components/voice_memo/ | New voice memo component implementation with recording controls, audio visualization, and state management |
packages/zeta_flutter/lib/src/interfaces/audio_decoder.dart | Audio amplitude decoder interface for waveform generation |
packages/zeta_flutter/lib/src/components/progress/progress_circle.dart | Enhanced progress circle with center widget support and animation duration |
packages/zeta_flutter_utils/lib/src/extensions.dart | New duration formatting and list utility extensions |
widgetbook/ | Widgetbook integration and platform-specific audio plugin configurations |
example/ | Example implementation and platform audio permissions setup |
Files not reviewed (1)
- widgetbook/ios/Runner.xcworkspace/contents.xcworkspacedata: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
packages/zeta_flutter/lib/src/components/voice_memo/ui/waveform.dart
Outdated
Show resolved
Hide resolved
packages/zeta_flutter/lib/src/components/voice_memo/state/playback_state.dart
Show resolved
Hide resolved
packages/zeta_flutter/lib/src/components/voice_memo/state/wav_amplitude_decoder.dart
Outdated
Show resolved
Hide resolved
…m.dart Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…amplitude_decoder.dart Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
'Can Record' Widgetbook prop is intermittent. The message 'Recording not allowed' flashes up but then dissapears and user is able to record even if 'Can Record' is false. Nitpick items (Purely UI/Cosmetic & not essential):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the can record prop bug
chore: Add animation duration to ZetaProgressIndicator / Circle and added center component to ZetaProgressCircle