This repository has been archived by the owner on Jan 21, 2022. It is now read-only.
Disposing many viewers at once fixes #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 6, 2020 09:56
…ceptions when many viewers are opened/closed. (Internal Array Size not sufficient when inserting on many threads).
This was referenced May 6, 2020
|
Thanks, 👍 |
|
Thanks ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a use-case where I open many viewers (6-9) at once and when I'm done, I dispose of them all too. I encountered two exceptions.
Issue #639 -- a null reference exception
Issue #640 -- an index out of range exception
I believe this pull request fixes both those issues because I've been using the modified .dlls in my solution for a few days without these exceptions reoccurring.