Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(state): Avoids panicking during contextual validation when a parent block is missing #8883

Merged
merged 1 commit into from
Sep 23, 2024
Merged

fix(state): Avoids panicking during contextual validation when a parent block is missing #8883

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions zebra-state/src/service/check.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,16 @@ where
.take(POW_ADJUSTMENT_BLOCK_SPAN)
.collect();

let parent_block = relevant_chain
.first()
.expect("state must contain parent block to do contextual validation");
let Some(parent_block) = relevant_chain.first() else {
warn!(
?semantically_verified,
?finalized_tip_height,
"state must contain parent block to do contextual validation"
);

return Err(ValidateContextError::NotReadyToBeCommitted);
};

let parent_block = parent_block.borrow();
let parent_height = parent_block
.coinbase_height()
Expand Down
Loading