change(consensus): Allow configurable NU5 activation height on Regtest #8505
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to allow configuring an NU5 activation height on Regtest. This was removed in a recent PR because I thought Zebra didn't support Canopy block construction, it does, it was the
proposal_block_from_template()
function used in tests and the internal-miner that only worked with NU5.PR Author Checklist
Check before marking the PR as ready for review:
For significant changes:
If a checkbox isn't relevant to the PR, mark it as done.
Solution
current_network_upgrade
argument inproposal_block_from_template()
testnet_parameters.activation_heights.nu5
field as the NU5 activation height on RegtestRelated Changes:
with_activation_heights()
to overwrite activation heights for all network upgrades except Genesiscurrent_with_activation_height()
method and uses it inCommitment::from_bytes()
Testing
The
regtest_submit_blocks()
test was updated to submit Canopy blocks and switch to NU5 blocks at height 100Review
Anyone can review.
Reviewer Checklist
Check before approving the PR:
PR blockers can be dealt with in new tickets or PRs.
And check the PR Author checklist is complete.