Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(config): Allow square brackets in network config listen addr and external addr #8504

Merged
merged 1 commit into from
May 7, 2024

Conversation

arya2
Copy link
Contributor

@arya2 arya2 commented May 3, 2024

Motivation

Closes #8476.

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Have you added or updated tests?
  • Is the documentation up to date?
For significant changes:
  • Is there a summary in the CHANGELOG?
  • Can these changes be split into multiple PRs?

If a checkbox isn't relevant to the PR, mark it as done.

Solution

Try adding the default port to the config value and parsing that as a SocketAddr before trying to parse it as an IpAddr

Testing

Manually tested that the config accepts [::]

Review

Anyone can review.

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

@arya2 arya2 self-assigned this May 3, 2024
@arya2 arya2 requested a review from a team as a code owner May 3, 2024 16:53
@arya2 arya2 requested review from oxarbitrage and removed request for a team May 3, 2024 16:53
@arya2 arya2 added I-usability Zebra is hard to understand or use do-not-merge Tells Mergify not to merge this PR labels May 3, 2024
@oxarbitrage oxarbitrage removed the do-not-merge Tells Mergify not to merge this PR label May 7, 2024
Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

mergify bot added a commit that referenced this pull request May 7, 2024
@mergify mergify bot merged commit 3e264c7 into main May 7, 2024
137 checks passed
@mergify mergify bot deleted the accept-bracket-ip branch May 7, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I-usability Zebra is hard to understand or use P-Optional ✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

listen_addr doesn't accept "[::]"
2 participants