-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add(test): Check that scan task removes keys, unify scan task acceptance tests, and add test to CI #8308
Conversation
45cda8b
to
6110424
Compare
6110424
to
04de1b6
Compare
Thank you @gustavovalverde for finding the issue! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is good to go!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Motivation
We want to check that the scan task removes keys after receiving
RemoveKeys
messages.Closes #8286
Closes #8274
Closes #8259
PR Author Checklist
Check before marking the PR as ready for review:
For significant changes:
If a checkbox isn't relevant to the PR, mark it as done.
Solution
scans_for_new_key
test nowscan_subscribe_results
test toscan_task_commands
scan_task.remove_keys()
fromscan_task_commands
testDisconnected
errorRelated Cleanups:
remove_keys()
to accept aVec
instead of a slice.Review
Anyone can review.
Reviewer Checklist
Check before approving the PR:
PR blockers can be dealt with in new tickets or PRs.
And check the PR Author checklist is complete.