Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add(test): Check that scan task removes keys, unify scan task acceptance tests, and add test to CI #8308

Merged
merged 5 commits into from
Mar 4, 2024

Conversation

arya2
Copy link
Contributor

@arya2 arya2 commented Feb 21, 2024

Motivation

We want to check that the scan task removes keys after receiving RemoveKeys messages.

Closes #8286
Closes #8274
Closes #8259

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Have you added or updated tests?
  • Is the documentation up to date?
For significant changes:
  • Is there a summary in the CHANGELOG?
  • Can these changes be split into multiple PRs?

If a checkbox isn't relevant to the PR, mark it as done.

Solution

  • Deletes the scans_for_new_key test now
  • Renames scan_subscribe_results test to scan_task_commands
  • Calls scan_task.remove_keys() from scan_task_commands test
  • Waits for the scan task to drop the results sender, then:
    • Empties the results channel
    • Asserts that the first error is a Disconnected error

Related Cleanups:

  • Updates remove_keys() to accept a Vec instead of a slice.

Review

Anyone can review.

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

@arya2 arya2 added A-devops Area: Pipelines, CI/CD and Dockerfiles C-testing Category: These are tests A-blockchain-scanner Area: Blockchain scanner of shielded transactions P-Medium ⚡ labels Feb 21, 2024
@arya2 arya2 self-assigned this Feb 21, 2024
@arya2 arya2 requested review from a team as code owners February 21, 2024 22:44
@arya2 arya2 requested review from oxarbitrage and removed request for a team February 21, 2024 22:44
@arya2 arya2 changed the title add(test): Check that scan task removes keys, unify scan task acceptance tests, and add test to CI add(test): Check that scan task removes keys, unifies scan task acceptance tests, and adds test to CI Feb 21, 2024
@github-actions github-actions bot added C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG extra-reviews This PR needs at least 2 reviews to merge labels Feb 21, 2024
Base automatically changed from fix-scan-rpc-bug to main February 21, 2024 23:29
@arya2 arya2 force-pushed the merge-scan-task-tests branch from 45cda8b to 6110424 Compare February 21, 2024 23:31
@arya2 arya2 force-pushed the merge-scan-task-tests branch from 6110424 to 04de1b6 Compare February 21, 2024 23:57
@arya2 arya2 changed the title add(test): Check that scan task removes keys, unifies scan task acceptance tests, and adds test to CI add(test): Check that scan task removes keys, unify scan task acceptance tests, and add test to CI Feb 22, 2024
@arya2 arya2 added do-not-merge Tells Mergify not to merge this PR and removed do-not-merge Tells Mergify not to merge this PR extra-reviews This PR needs at least 2 reviews to merge labels Feb 23, 2024
@github-actions github-actions bot added the extra-reviews This PR needs at least 2 reviews to merge label Feb 26, 2024
@arya2
Copy link
Contributor Author

arya2 commented Feb 26, 2024

Thank you @gustavovalverde for finding the issue!

Copy link
Member

@gustavovalverde gustavovalverde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is good to go!

Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

Copy link
Member

@gustavovalverde gustavovalverde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

mergify bot added a commit that referenced this pull request Mar 4, 2024
@mergify mergify bot merged commit e64f3dc into main Mar 4, 2024
192 checks passed
@mergify mergify bot deleted the merge-scan-task-tests branch March 4, 2024 21:25
@arya2 arya2 mentioned this pull request Apr 15, 2024
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-blockchain-scanner Area: Blockchain scanner of shielded transactions A-devops Area: Pipelines, CI/CD and Dockerfiles C-testing Category: These are tests C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG extra-reviews This PR needs at least 2 reviews to merge P-Medium ⚡
Projects
None yet
3 participants