-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(grpc): Add initial Getinfo
grpc
#8178
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, i am not really sure if the failing test is related to this PR. https://github.com/ZcashFoundation/zebra/actions/runs/7661775200/job/20881794125?pr=8178
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Motivation
We want to get started with the grpc methods by adding a first dummy call that will work as the framework to add other more interesting ones.
Part of #8162
Depend on #8167
PR Author Checklist
Check before marking the PR as ready for review:
Solution
I followed the hello world example of tonic (https://github.com/hyperium/tonic/blob/master/examples/helloworld-tutorial.md) and adapted to our needs.
Access to the scanner database will be done by a service at #8185 . We want to add some real info to this method after that.
This is the most basic and smaller piece i was able to build.
Testing
No testing was done here, only manual testing.
In the server side the grpc endpoint can be started with:
Then the client can make a call with:
I think we should make tests by using client code at https://github.com/hyperium/tonic/blob/master/examples/helloworld-tutorial.md#writing-our-client
Review
I think anyone that will be working in the grpc methods we are about to develop can review.
Reviewer Checklist
Check before approving the PR:
PR blockers can be dealt with in new tickets or PRs.
And check the PR Author checklist is complete.
Follow Up Work