Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imp(ci): fix codespell words and ignore others #8089

Merged
merged 1 commit into from
Dec 11, 2023
Merged

imp(ci): fix codespell words and ignore others #8089

merged 1 commit into from
Dec 11, 2023

Conversation

gustavovalverde
Copy link
Member

Motivation

This cleans the annotations on every PR, so it doesn't show up from now on.

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Have you added or updated tests?
  • Is the documentation up to date?
For significant changes:
  • Is there a summary in the CHANGELOG?
  • Can these changes be split into multiple PRs?

If a checkbox isn't relevant to the PR, mark it as done.

Solution

  • Add ignore words .codespellrc
  • Fix other words across the codebase

Review

Nothing special here.

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

@gustavovalverde
imp(ci): fix codespell words and ignore others
b38b739 
This cleans the annotations on every PR, so it doesn't show up from now on.
@gustavovalverde gustavovalverde requested a review from a team as a code owner December 11, 2023 22:01
@gustavovalverde gustavovalverde requested review from arya2 and removed request for a team December 11, 2023 22:01
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Dec 11, 2023
@teor2345 teor2345 added C-bug Category: This is a bug A-devops Area: Pipelines, CI/CD and Dockerfiles P-Critical 🚑 labels Dec 11, 2023
teor2345
teor2345 approved these changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, let's clear this from all PRs

mergify bot added a commit that referenced this pull request Dec 11, 2023
@mergify
Merge of #8089
5b3293a
@mergify mergify bot mentioned this pull request Dec 11, 2023
Closed
@mergify mergify bot merged commit e5b810a into main Dec 11, 2023
94 checks passed
@mergify mergify bot deleted the exclude-codespell-words branch December 11, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teor2345 teor2345 teor2345 approved these changes

@arya2 arya2 Awaiting requested review from arya2 arya2 is a code owner automatically assigned from ZcashFoundation/general-rust-reviewers

Assignees
No one assigned
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-bug Category: This is a bug C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gustavovalverde @teor2345