Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(testing): Add a testnet forking tutorial #7995

Merged
merged 1 commit into from
Nov 26, 2023
Merged

docs(testing): Add a testnet forking tutorial #7995

merged 1 commit into from
Nov 26, 2023

Conversation

oxarbitrage
Copy link
Contributor

Motivation

We want to have a tutorial to describe how to test post network upgrade functionality in a private testnet way.

Close #7921

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Have you added or updated tests?
  • Is the documentation up to date?

Solution

The tutorial written is based on notes the zebra team shared with other teams and my own experience trying this out locally.

Review

Anyone can review. I am open to make changes.

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

@oxarbitrage oxarbitrage added A-docs Area: Documentation P-Low ❄️ C-testing Category: These are tests labels Nov 26, 2023
@oxarbitrage oxarbitrage requested a review from a team as a code owner November 26, 2023 14:45
@oxarbitrage oxarbitrage requested review from arya2 and removed request for a team November 26, 2023 14:45
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Nov 26, 2023
teor2345
teor2345 approved these changes Nov 26, 2023
View reviewed changes
Copy link
Collaborator

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Since we have teams waiting to see these docs, let's merge the draft now, and change it when we get feedback, or when we notice things?

@mergify mergify bot merged commit 193fd42 into main Nov 26, 2023
92 checks passed
@mergify mergify bot deleted the forking-testnet-tutorial branch November 26, 2023 21:34
@arya2 arya2 mentioned this pull request Nov 29, 2023
Merged
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teor2345 teor2345 teor2345 approved these changes

@arya2 arya2 Awaiting requested review from arya2 arya2 is a code owner automatically assigned from ZcashFoundation/general-rust-reviewers

Assignees
No one assigned
Labels
A-docs Area: Documentation C-testing Category: These are tests C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a tutorial for forking the testnet blockchain
2 participants
@oxarbitrage @teor2345