Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(clippy): Remove unnecessary try_into() with cargo clippy --fix #7940

Merged
merged 6 commits into from
Nov 14, 2023

Conversation

teor2345
Copy link
Collaborator

@teor2345 teor2345 commented Nov 14, 2023

Motivation

This is a routine cleanup of nightly clippy warnings.

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Have you added or updated tests?
  • Is the documentation up to date?

Not a significant or user change, no test or doc changes needed.

If a checkbox isn't relevant to the PR, mark it as done.

Complex Code or Requirements

Is the code change in Orchard correct? Is every diversifier value a valid point?

Solution

Remove unnecessary try_from() using Clippy.

Testing

This already has test coverage.

Review

This is a low priority cleanup.

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

@teor2345 teor2345 added A-rust Area: Updates to Rust code C-cleanup Category: This is a cleanup P-Low ❄️ C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Nov 14, 2023
@teor2345 teor2345 self-assigned this Nov 14, 2023
@teor2345 teor2345 requested review from a team as code owners November 14, 2023 05:46
@teor2345 teor2345 requested review from arya2 and upbqdn and removed request for a team November 14, 2023 05:46
@github-actions github-actions bot added the extra-reviews This PR needs at least 2 reviews to merge label Nov 14, 2023
Copy link
Member

@upbqdn upbqdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the code change in Orchard correct?

Yes.

Is every diversifier value a valid point?

Yes.

@teor2345 teor2345 removed the extra-reviews This PR needs at least 2 reviews to merge label Nov 14, 2023
@mergify mergify bot merged commit af82a76 into main Nov 14, 2023
104 checks passed
@mergify mergify bot deleted the clippy-2023-11-14 branch November 14, 2023 20:31
@arya2 arya2 mentioned this pull request Nov 29, 2023
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rust Area: Updates to Rust code C-cleanup Category: This is a cleanup C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants