Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup(deps): Bump sha2 and secp256k1 to remove duplicate dependencies #7238

Merged
merged 2 commits into from
Jul 18, 2023
Merged

cleanup(deps): Bump sha2 and secp256k1 to remove duplicate dependencies #7238

merged 2 commits into from
Jul 18, 2023

Conversation

arya2
Copy link
Contributor

@arya2 arya2 commented Jul 17, 2023

Motivation

This PR removes duplicate dependencies in Zebra where possible.

Close #6638.

Solution

  • Use latest versions of sha2 and secp256k1 in zebra-chain
  • Update deny.toml

Review

Anyone can review.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

@arya2 arya2 self-assigned this Jul 17, 2023
@arya2 arya2 requested a review from a team as a code owner July 17, 2023 22:50
@arya2 arya2 requested review from teor2345 and removed request for a team July 17, 2023 22:50
@github-actions github-actions bot added C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG extra-reviews This PR needs at least 2 reviews to merge labels Jul 17, 2023
@teor2345 teor2345 added A-dependencies Area: Dependency file updates P-High 🔥 A-cryptography Area: Cryptography related and removed extra-reviews This PR needs at least 2 reviews to merge labels Jul 17, 2023
teor2345
teor2345 previously approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I checked that the redundant duplicate dependency exceptions have been removed:
https://github.com/ZcashFoundation/zebra/actions/runs/5581373940/jobs/10199448264?pr=7238#step:5:14

@arya2 arya2 requested a review from a team as a code owner July 17, 2023 23:07
@arya2 arya2 requested a review from teor2345 July 17, 2023 23:07
@github-actions github-actions bot added the extra-reviews This PR needs at least 2 reviews to merge label Jul 17, 2023
@arya2 arya2 removed the extra-reviews This PR needs at least 2 reviews to merge label Jul 17, 2023
dconnolly
dconnolly approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@dconnolly dconnolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 📜

mergify bot added a commit that referenced this pull request Jul 18, 2023
@mergify
Merge of #7238
4da828f
@mergify mergify bot mentioned this pull request Jul 18, 2023
Closed
mergify bot added a commit that referenced this pull request Jul 18, 2023
@mergify
Merge of #7238
2d3c84c
@mergify mergify bot mentioned this pull request Jul 18, 2023
Closed
mergify bot added a commit that referenced this pull request Jul 18, 2023
@mergify
Merge of #7238
2d6bce3
@mergify mergify bot mentioned this pull request Jul 18, 2023
Closed
@teor2345 teor2345 removed their request for review July 18, 2023 06:06
@mergify mergify bot merged commit 62f7172 into main Jul 18, 2023
@mergify mergify bot deleted the rm-dup-deps branch July 18, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dconnolly dconnolly dconnolly approved these changes

@teor2345 teor2345 teor2345 left review comments

Assignees

@arya2 arya2

Labels
A-cryptography Area: Cryptography related A-dependencies Area: Dependency file updates C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove duplicate dependencies from deny.toml once ed25519-zebra and zcashd are released
3 participants
@arya2 @dconnolly @teor2345