Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): Add extra patch job for cargo deny checks #7086

Merged
merged 1 commit into from
Jul 6, 2023
Merged

fix(ci): Add extra patch job for cargo deny checks #7086

merged 1 commit into from
Jul 6, 2023

Conversation

teor2345
Copy link
Collaborator

@teor2345 teor2345 commented Jun 27, 2023 •
edited
Loading

Motivation

I added a new deny.toml check in a previous PR, but I forgot to update the patch job.

  • Admin: add the job to the branch protection rules

Review

This is a low priority cleanup/fix.

Reviewer Checklist

  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

@teor2345 teor2345 added C-bug Category: This is a bug A-devops Area: Pipelines, CI/CD and Dockerfiles P-Low ❄️ C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Jun 27, 2023
@teor2345 teor2345 requested a review from a team as a code owner June 27, 2023 22:00
@teor2345 teor2345 self-assigned this Jun 27, 2023
@teor2345 teor2345 requested review from gustavovalverde and removed request for a team June 27, 2023 22:00
@github-actions github-actions bot added the C-feature Category: New features label Jun 27, 2023
@teor2345 teor2345 added do-not-merge Tells Mergify not to merge this PR and removed do-not-merge Tells Mergify not to merge this PR labels Jun 30, 2023
upbqdn
upbqdn approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@upbqdn upbqdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

mergify bot added a commit that referenced this pull request Jul 5, 2023
@mergify
Merge of #7086
f4729d8
@mergify mergify bot mentioned this pull request Jul 5, 2023
Closed
@mergify mergify bot merged commit 83c459d into main Jul 6, 2023
@mergify mergify bot deleted the fix-deny-patch-jobs branch July 6, 2023 01:04
@teor2345
Copy link
Collaborator Author

teor2345 commented Jul 9, 2023

I just added this to the branch protection rules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upbqdn upbqdn upbqdn approved these changes

@gustavovalverde gustavovalverde Awaiting requested review from gustavovalverde gustavovalverde is a code owner automatically assigned from ZcashFoundation/devops-reviewers

Assignees

@teor2345 teor2345

Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-bug Category: This is a bug C-feature Category: New features C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teor2345 @upbqdn