Skip to content

change(docker): Replace the zcash-params Dockerfile build with a zebrad binary copy #7054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 28, 2023
Merged

change(docker): Replace the zcash-params Dockerfile build with a zebrad binary copy #7054

merged 2 commits into from
Jun 28, 2023

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Jun 23, 2023 •
edited
Loading

Motivation

We currently build zebrad in both docker/Dockerfile and docker/zcash-params/Dockerfile.

But we don't need to build zebrad again, we can just re-use the test or release binaries.

Complex Code or Requirements

This slightly increases the risk we break the zebrad download command and don't notice for a while.

Solution

  • Instead of building zebrad, copy any recently built zebrad test binary

Related fixes:

  • Update the workflow run files for the zcash-params.yml workflow

Review

This is a low priority cleanup.

Reviewer Checklist

  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

@teor2345 teor2345 added A-devops Area: Pipelines, CI/CD and Dockerfiles C-cleanup Category: This is a cleanup P-Low ❄️ C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Jun 23, 2023
@teor2345 teor2345 self-assigned this Jun 23, 2023
@teor2345 teor2345 requested a review from a team as a code owner June 23, 2023 02:25
@teor2345 teor2345 requested review from arya2 and removed request for a team June 23, 2023 02:25
@github-actions github-actions bot added the C-enhancement Category: This is an improvement label Jun 23, 2023
gustavovalverde
gustavovalverde previously approved these changes Jun 25, 2023
View reviewed changes
Copy link
Member

@gustavovalverde gustavovalverde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

LGTM

@teor2345 teor2345 requested review from a team as code owners June 26, 2023 00:52
@teor2345 teor2345 force-pushed the cleanup-params-dockerfile branch from b511a0d to 8aaed15 Compare June 26, 2023 00:55
Base automatically changed from no-openssl to main June 26, 2023 05:44
@mergify mergify bot dismissed gustavovalverde’s stale review June 26, 2023 05:44

The base branch was changed.

@teor2345 teor2345 force-pushed the cleanup-params-dockerfile branch 2 times, most recently from b1edf58 to a9a05df Compare June 27, 2023 03:16
@teor2345 teor2345 force-pushed the cleanup-params-dockerfile branch from a9a05df to 0f6f0e1 Compare June 27, 2023 03:19
@teor2345
Copy link
Contributor Author

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Jun 27, 2023

refresh

✅ Pull request refreshed

mergify bot added a commit that referenced this pull request Jun 28, 2023
@mergify
Merge of #7054
1d1e02f
@mergify mergify bot mentioned this pull request Jun 28, 2023
Closed
@mergify mergify bot merged commit 62b4fa2 into main Jun 28, 2023
@mergify mergify bot deleted the cleanup-params-dockerfile branch June 28, 2023 02:34
@arya2 arya2 mentioned this pull request Jun 28, 2023
Merged
44 tasks
@teor2345 teor2345 mentioned this pull request Jun 28, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arya2 arya2 arya2 approved these changes

@gustavovalverde gustavovalverde gustavovalverde approved these changes

Assignees

@teor2345 teor2345

Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-cleanup Category: This is a cleanup C-enhancement Category: This is an improvement C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@teor2345 @arya2 @gustavovalverde