Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(test): Make test debugging output more readable #7027

Merged
merged 2 commits into from
Jun 21, 2023

Conversation

teor2345
Copy link
Collaborator

Motivation

Sometimes Zebra produces 30,000 lines of debug output from a single test:
https://github.com/ZcashFoundation/zebra/actions/runs/5321638950/jobs/9636992835?pr=7019#step:10:4911

Some Zebra structs have debug impls which print arrays of u8, rather than hex-encoded strings.

Solution

Hide the extremely long debug output.

Manually implement the debug impls to use hex encoded strings.

Review

This is a low priority cleanup.

Reviewer Checklist

  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

@teor2345 teor2345 added C-cleanup Category: This is a cleanup P-Low ❄️ A-diagnostics Area: Diagnosing issues or monitoring performance C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Jun 20, 2023
@teor2345 teor2345 requested review from a team as code owners June 20, 2023 23:20
@teor2345 teor2345 self-assigned this Jun 20, 2023
@teor2345 teor2345 requested a review from a team as a code owner June 20, 2023 23:20
@teor2345 teor2345 requested review from upbqdn and removed request for a team June 20, 2023 23:20
@github-actions github-actions bot added the C-bug Category: This is a bug label Jun 20, 2023
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #7027 (f0fcbc2) into main (b40fc9b) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7027      +/-   ##
==========================================
+ Coverage   77.39%   77.44%   +0.04%     
==========================================
  Files         310      310              
  Lines       41635    41669      +34     
==========================================
+ Hits        32224    32270      +46     
+ Misses       9411     9399      -12     

Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one, looks good to me.

mergify bot added a commit that referenced this pull request Jun 21, 2023
@mergify mergify bot merged commit 343a683 into main Jun 21, 2023
@mergify mergify bot deleted the fix-proptest-debug-data branch June 21, 2023 15:02
@teor2345 teor2345 mentioned this pull request Jun 28, 2023
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Diagnosing issues or monitoring performance C-bug Category: This is a bug C-cleanup Category: This is a cleanup C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants