-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add(metrics): Track mempool actions and size bucketed by weight (copy of #6972, credit @str4d) #7019
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
@Mergifyio refresh |
✅ Pull request refreshed |
This seems like a real bug, but I don't know if it is in the generated proptest data, or in the code. Multiple tests fail on the same Rust code in this PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Panic on "attempt to subtract with overflow"
6aa59e7
to
a0aa703
Compare
@oxarbitrage CI won't run on this branch until you fix the merge conflicts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
It looks like all the tests are passing, but we're not quite testing the correct ranges.
Also we could make this implementation simpler and easier to use by replacing the derived Arbitrary
implementation with a manual one. Did you want me to show you how to do that?
CI hit a GitHub HTTP request rate-limit:
https://github.com/ZcashFoundation/zebra/actions/runs/5590449347/jobs/10221580034?pr=7019#step:2:54 The solution to this is to stop checking out Zebra in jobs and steps that don't need it, or to combine jobs and steps so that we check out Zebra fewer times. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this up!
Motivation
This is a copy of #6972 so that tests can be run
Specifications
Complex Code or Requirements
Solution
Review
Reviewer Checklist
Follow Up Work