fix(deploy): allow the container to raise in MIGs #6893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C-bug
gustavovalverde
added
A-infrastructure
teor2345
reviewed
Jun 9, 2023
These further changes could be optional. For testing, it's enough to just run a scheduled full sync in our test environment. To support the network, using a cached state will be better because the instances are live faster. |
This no longer requires the env variable to be defined in other places, unless we're changing the default configuration
teor2345
previously approved these changes
Jun 9, 2023
6 tasks
dconnolly
approved these changes
Jun 9, 2023
dconnolly
pushed a commit
that referenced
this pull request
Jun 12, 2023
* fix(deploy): allow the container to raise in MIGs * fix(docker): add the `ZEBRA_CACHED_STATE_DIR` as a default `ENV` This no longer requires the env variable to be defined in other places, unless we're changing the default configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The Managed Instance Groups in GCP were not raising the container as those were expecting the device name and the correct RW/RO mode to match between the created disk and the disk we're mounting in the container.
This also fixes monitoring, and uses the same caching directory as in CI, as the Container Optimized Image does not allow mounting in non-standard linux paths for security reasons.
Fixes: #5644
Fixes: #6861
Specifications
See: https://cloud.google.com/sdk/gcloud/reference/compute/instance-templates/create-with-container#--container-mount-disk
Solution
--boot-disk-size 300GBto the MIGs template, just as we have on CI and Single instance deploystdinandttyto standardize with other approachesZEBRA_CACHED_STATE_DIRwith/var/cache/zebrad-cacheas we do on CI, as thecos-clouddoesn't behave correctly with non-standard paths.Review
Anyone from DevOps
Reviewer Checklist
Follow Up Work
We should make further changes in a following PR:
For releases, it should sync from scratch (1). Currently it's 2-4 weeks between releases, so a 3 day mainnet sync is ok.
For
mainbranch pushes, it should have a cached state (2 or 3, whatever is easier or more reliable). We merge new PRs multiple times a day, so a cached state is needed.