Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(release-checklist): add cargo update steps to task list #6657

Merged
merged 3 commits into from
May 14, 2023
Merged

docs(release-checklist): add cargo update steps to task list #6657

merged 3 commits into from
May 14, 2023

Conversation

oxarbitrage
Copy link
Contributor

Motivation

The cargo update steps were missing in original PR for the next release (#6632 (comment)).

I think that to to make sure this is done we can add the steps of it to the tasklist.

Solution

Add cargo update steps as task list.

Review

Anyone can review.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

@oxarbitrage oxarbitrage requested a review from a team as a code owner May 10, 2023 19:19
@oxarbitrage oxarbitrage requested review from teor2345 and removed request for a team May 10, 2023 19:19
@oxarbitrage oxarbitrage self-assigned this May 10, 2023
@oxarbitrage oxarbitrage added A-docs Area: Documentation P-Low ❄️ labels May 10, 2023
@github-actions github-actions bot added C-feature Category: New features C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels May 10, 2023
@oxarbitrage @teor2345
Apply suggestions from code review
17a316f 
Co-authored-by: teor <teor@riseup.net>
mergify bot added a commit that referenced this pull request May 13, 2023
@mergify
Merge of #6657
1e2c5b4
@mergify mergify bot mentioned this pull request May 13, 2023
Closed
mergify bot added a commit that referenced this pull request May 14, 2023
@mergify
Merge of #6657
8dcebbd
@mergify mergify bot mentioned this pull request May 14, 2023
Closed
@mergify mergify bot merged commit c76d1f5 into main May 14, 2023
@mergify mergify bot deleted the update-release-checklist branch May 14, 2023 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teor2345 teor2345 teor2345 approved these changes

Assignees

@oxarbitrage oxarbitrage

Labels
A-docs Area: Documentation C-feature Category: New features C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oxarbitrage @teor2345