-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change(ci): Generate testnet checkpoints in CI #6581
Conversation
b16aa89
to
4806f17
Compare
Manual testing: The mainnet checkpoints from CI are:
https://github.com/ZcashFoundation/zebra/actions/runs/4816455207/jobs/8576823182#step:8:265 I manually generated mainnet checkpoints using my local
The testnet checkpoints from CI are:
https://github.com/ZcashFoundation/zebra/actions/runs/4816455207/jobs/8579149326#step:8:235 I manually generated testnet checkpoints using my local
These are the same except for the last 2 checkpoints, because I did the manual generation today, but the CI job was from yesterday. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great; future iteration, it automatically opens a PR with the updated checkpoints, as long as that's not on every change? That would be if we have a specific release flow, or something
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is ready for re-approval, just needed to resolve some minor comment merge conflicts from the previous PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! <3
Motivation
We want to automatically generate checkpoints in CI on testnet.
Closes #6367
Solution
main
, and when the cached state is missing, because it takes about 2 hours to runReview
This is a routine change.
Reviewer Checklist
Follow Up Work
Re-order the jobs so the dependency graph is clearer - full syncs should all be near the top after the build
https://github.com/ZcashFoundation/zebra/actions/runs/4814515102