Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(consensus): bump incrementalmerkletree from 0.3.0 to 0.3.1, resolving a consensus bug on 32-bit platforms #6258

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 1, 2023

Bumps incrementalmerkletree from 0.3.0 to 0.3.1.

Changelog

Sourced from incrementalmerkletree's changelog.

[0.3.1] - 2023-02-28

Fixed

  • A bug affecting 32-bit platforms caused Position::max_altitude to return the wrong value. This typically manifested as failures to add commitments to the tree.
Commits
  • d91890d Release incrementalmerkletree v0.3.1
  • 06af5ac Merge pull request #57 from daira/max-altitude-bug
  • 34551a0 Pin proptest dependency to 1.0.0 to avoid unstable unarray dep.
  • 86f0903 Fix a bug on 32-bit platforms that caused Position::max_altitude to return
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [incrementalmerkletree](https://github.com/zcash/incrementalmerkletree) from 0.3.0 to 0.3.1.
- [Release notes](https://github.com/zcash/incrementalmerkletree/releases)
- [Changelog](https://github.com/zcash/incrementalmerkletree/blob/incrementalmerkletree-v0.3.1/CHANGELOG.md)
- [Commits](zcash/incrementalmerkletree@incrementalmerkletree-v0.3.0...incrementalmerkletree-v0.3.1)

---
updated-dependencies:
- dependency-name: incrementalmerkletree
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from a team as a code owner March 1, 2023 16:57
@dependabot dependabot bot requested review from oxarbitrage and removed request for a team March 1, 2023 16:57
@dependabot dependabot bot added A-dependencies Area: Dependency file updates A-rust Area: Updates to Rust code C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-Low ❄️ labels Mar 1, 2023
@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Merging #6258 (eec6068) into main (8f50716) will decrease coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6258      +/-   ##
==========================================
- Coverage   78.00%   77.96%   -0.04%     
==========================================
  Files         304      304              
  Lines       39349    39349              
==========================================
- Hits        30693    30678      -15     
- Misses       8656     8671      +15     

@teor2345 teor2345 added C-bug Category: This is a bug A-consensus Area: Consensus rule updates P-High 🔥 I-consensus Zebra breaks a Zcash consensus rule and removed P-Low ❄️ labels Mar 1, 2023
@teor2345 teor2345 self-assigned this Mar 1, 2023
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a high-priority consensus-critical bug fix for 32-bit platforms.

Edit: we don't support those platforms, but we should apply this fix anyway.

@teor2345 teor2345 changed the title build(deps): bump incrementalmerkletree from 0.3.0 to 0.3.1 fix(consensus): bump incrementalmerkletree from 0.3.0 to 0.3.1, resolving a consensus bug on 32-bit platforms Mar 1, 2023
@mergify mergify bot merged commit 639cc76 into main Mar 1, 2023
@mergify mergify bot deleted the dependabot/cargo/incrementalmerkletree-0.3.1 branch March 1, 2023 20:44
@oxarbitrage oxarbitrage mentioned this pull request Mar 23, 2023
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-consensus Area: Consensus rule updates A-dependencies Area: Dependency file updates A-rust Area: Updates to Rust code C-bug Category: This is a bug C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG I-consensus Zebra breaks a Zcash consensus rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant