Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(consensus): Update mainnet and testnet checkpoints #5360

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Oct 7, 2022

Motivation

We're seeing some slow syncs, updating the checkpoints might help.

Review

This is routine, but required for tagging the release candidate.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
  • How do you know it works? Does it have tests?

@teor2345 teor2345 added A-consensus Area: Consensus rule updates C-enhancement Category: This is an improvement P-Medium ⚡ labels Oct 7, 2022
@teor2345 teor2345 requested a review from a team as a code owner October 7, 2022 08:23
@teor2345 teor2345 self-assigned this Oct 7, 2022
@teor2345 teor2345 requested review from oxarbitrage and removed request for a team October 7, 2022 08:23
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Oct 7, 2022
@codecov
Copy link

codecov bot commented Oct 7, 2022

Codecov Report

Merging #5360 (9c3cd2f) into main (7207f9d) will decrease coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5360      +/-   ##
==========================================
- Coverage   79.19%   79.16%   -0.04%     
==========================================
  Files         308      308              
  Lines       39560    39560              
==========================================
- Hits        31329    31317      -12     
- Misses       8231     8243      +12     

@teor2345
Copy link
Contributor Author

teor2345 commented Oct 7, 2022

Failed ssh connection, see #5362 for details

@teor2345
Copy link
Contributor Author

Failed due to #5366, logs in that ticket.

@arya2
Copy link
Contributor

arya2 commented Oct 10, 2022

I added some intermediate jobs between logs-1790k and logs-checkpoint in #5372

@teor2345
Copy link
Contributor Author

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Oct 11, 2022

refresh

✅ Pull request refreshed

@teor2345
Copy link
Contributor Author

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Oct 11, 2022

refresh

✅ Pull request refreshed

@teor2345
Copy link
Contributor Author

teor2345 commented Oct 11, 2022

The macOS job failed while building the Zcash parameter path binary, which is really unusual. (It's not particularly big, and it doesn't do much.)
https://github.com/ZcashFoundation/zebra/actions/runs/3223280477/jobs/5273188507#step:11:299

I'll try again, but if that doesn't work, we should clear the macOS build cache:
https://github.com/ZcashFoundation/zebra/blob/main/book/src/dev/continuous-integration.md#fixing-disk-full-errors-and-zcash-parameter-errors

And if that doesn't work, we can disable the macOS job, because macOS tests are not a release blocker. (Tier 2 doesn't guarantee tests will work.)

@teor2345
Copy link
Contributor Author

There was no test cache for this PR or main, but I deleted the clippy cache:

    {
      "id": 39427,
      "ref": "refs/heads/main",
      "key": "v0-rust-clippy-cargo-lock-1.64.0-x86_64-unknown-linux-gnu-a55dd71d5fb0-1b751ccaa4b37d9524c4",
      "version": "8a9936d632ad0d67adaee02f5d9fd8c1dddbbd5af8d94331392b76f17401cf6d",
      "last_accessed_at": "2022-10-11T01:06:11.716666700Z",
      "created_at": "2022-10-10T19:34:51.596666700Z",
      "size_in_bytes": 1203215728
    },

@teor2345
Copy link
Contributor Author

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Oct 11, 2022

refresh

✅ Pull request refreshed

mergify bot added a commit that referenced this pull request Oct 11, 2022
@mergify mergify bot merged commit 036a982 into main Oct 11, 2022
@mergify mergify bot deleted the checkpoints-2022-10-07 branch October 11, 2022 10:29
@teor2345 teor2345 mentioned this pull request Oct 11, 2022
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-consensus Area: Consensus rule updates C-enhancement Category: This is an improvement C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants