Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): Simplify GitHub actions caches #5104

Merged
merged 5 commits into from
Sep 7, 2022
Merged

fix(ci): Simplify GitHub actions caches #5104

merged 5 commits into from
Sep 7, 2022

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Sep 6, 2022 •
edited
Loading

Motivation

GitHub actions has a 10 GB cache limit per OS, and we're currently at the limit.

Disabling or merging some caches speeds up builds, and allows more PRs to use cached build files.

GitHub Actions Reference

Solution

  • Disable fmt job Rust cache, it's quick anyway
  • Merge the clippy and check-cargo-lock caches, they are a very similar size and do similar work

Related changes:

  • Fix the quoting in the Windows Rust target directory
  • Add a TODO for the Windows Rust cache path

Review

Anyone can review this PR, it might fix the beta Rust out of disk space errors.

Reviewer Checklist

  • CI passes

@teor2345 teor2345 added A-devops Area: Pipelines, CI/CD and Dockerfiles C-enhancement Category: This is an improvement P-High 🔥 I-heavy Problems with excessive memory, disk, or CPU usage labels Sep 6, 2022
@teor2345 teor2345 self-assigned this Sep 6, 2022
@teor2345 teor2345 marked this pull request as ready for review September 7, 2022 02:00
@teor2345 teor2345 requested a review from a team as a code owner September 7, 2022 02:00
@teor2345 teor2345 requested review from arya2 and removed request for a team September 7, 2022 02:00
teor2345
teor2345 commented Sep 7, 2022
View reviewed changes
.github/workflows/lint.yml Outdated Show resolved Hide resolved
mergify bot added a commit that referenced this pull request Sep 7, 2022
@mergify
Merge of #5104
3b948d5
@mergify mergify bot mentioned this pull request Sep 7, 2022
Closed
@mergify mergify bot merged commit 4639079 into main Sep 7, 2022
@mergify mergify bot deleted the simplify-caches branch September 7, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gustavovalverde gustavovalverde gustavovalverde approved these changes

@arya2 arya2 Awaiting requested review from arya2 arya2 is a code owner automatically assigned from ZcashFoundation/devops-reviewers

Assignees

@teor2345 teor2345

Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-enhancement Category: This is an improvement I-heavy Problems with excessive memory, disk, or CPU usage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teor2345 @gustavovalverde