feat(clippy): Add fallible_impl_from lint
#4609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxarbitrage
requested review from
dconnolly and
upbqdn
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## main #4609 +/- ##
==========================================
- Coverage 79.07% 78.92% -0.15%
==========================================
Files 304 304
Lines 37418 37421 +3
==========================================
- Hits 29589 29536 -53
- Misses 7829 7885 +56 |
teor2345
reviewed
Jun 14, 2022
|
I'm updating this PR, so I can see if the CI failures are from an old |
|
@Mergifyio update |
✅ Branch has been successfully updated |
conradoplg
previously requested changes
Jun 16, 2022
oxarbitrage
commented
Jun 16, 2022
|
Force pushed, this is now just c0c30ed |
|
@Mergifyio update |
✅ Branch has been successfully updated |
92 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In #2297 we want to add some panic lints to zebra. This is part 1 of 3 where the
fallible_impl_fromis added.Solution
Add the lint and fix the code where needed.
Review
Please review carefully, there are error messages that might be changed. I think @dconnolly wrote most of the changed code in orchard and sapling keys but anyone that can take a look is welcome.
Reviewer Checklist
Follow Up Work
We want to add 2 more related lints but i think it was too much to add them in a single PR so i splitted into 3.