ci(mergify): do not create draft PRs if not needed #4540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustavovalverde
added
C-bug
This reverts commit 32b309c.
conradoplg
approved these changes
Jun 1, 2022
|
Mergify configurations changes are not automatically merged. Merging manually |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We included Merge Freeze (https://www.mergefreeze.com/) as a tool to halt PRs when a critical path has to be accomplished, a release for example, and we don't want other PRs to get merged as this would invalidate part of the work being done for this critical path.
But we also have Mergify, which creates drafts PRs before merging (as we did not want all PRs being co-authored by Mergify), but those PRs also get freezed as those are not part of the exception rule, and are dynamically created.
Fixes #4137
Fixes Partially #3360
Closes #4110 (caused by a temporal mergify error)
Partially reverts: 6fafd1a
Solution
allow_inplace_checksReview
Anyone from @ZcashFoundation/devops-reviewers can review this
Follow Up Work