Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos #4397

Merged
merged 1 commit into from
May 16, 2022
Merged

Fix typos #4397

merged 1 commit into from
May 16, 2022

Conversation

rex4539
Copy link
Contributor

@rex4539 rex4539 commented May 14, 2022

No description provided.

@rex4539 rex4539 requested review from a team as code owners May 14, 2022 11:20
@rex4539 rex4539 requested review from teor2345 and removed request for a team May 14, 2022 11:20
teor2345
teor2345 suggested changes May 16, 2022
View reviewed changes
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these fixes!

We can't accept any changes to book/mermaid.min.js, because it is a generated file from an external source.

All the other changes are ok.

@teor2345 teor2345 added A-docs Area: Documentation C-cleanup Category: This is a cleanup P-Low ❄️ labels May 16, 2022
@rex4539 rex4539 requested a review from teor2345 May 16, 2022 03:35
mergify bot added a commit that referenced this pull request May 16, 2022
@mergify
Merge of #4397
8aa1b27
@mergify mergify bot mentioned this pull request May 16, 2022
Closed
48 tasks
@mergify mergify bot merged commit 59ae77d into ZcashFoundation:main May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teor2345 teor2345 teor2345 approved these changes

Assignees
No one assigned
Labels
A-docs Area: Documentation C-cleanup Category: This is a cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rex4539 @teor2345