3. Require network names in cached state disk names #4392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And prefer `main` to other branches.
Google Cloud doesn't seem to support regex groups.
And update a TODO
teor2345
added
C-bug
teor2345
force-pushed
the
req-net-in-cache-name
branch
from
f6905a2
to
562100b
Compare
Co-authored-by: teor <teor@riseup.net>
teor2345
commented
May 19, 2022
48 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As part of ticket #4153, we want to match cached states with the correct version and network.
In PR #4391, we fixed a bug where cached state disks were missing the network name.
Now that PR has merged to
main, and its state is rebuilt, we can require the network in disk names.Depends-On: #4385
Solution
Search for the exact network name in cached state disk names.
Review
Anyone can review this PR, it's not urgent.
Reviewer Checklist