fix(rpc): Check for panics in the transaction queue #4046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
C-enhancement
oxarbitrage
approved these changes
Apr 6, 2022
3 tasks
teor2345
added a commit
that referenced
this pull request
Apr 12, 2022
* Add a rpc queue * Implement the rpc queue * Add rpc queue tests * Remove mutex, use broadcast channel * Have order and limit in the queue * fix multiple transactions channel * Use a network argument * Use chain tip to calculate block spacing * Add extra time * Finalize the state check test * Add a retry test * Fix description * fix some docs * add additional empty check to `Runner::run` * remove non used method * ignore some errors * fix some docs * add a panic checker to the queue * add missing file changes for panic checker * skip checks and retries if height has not changed * change constants * reduce the number of queue test cases * remove suggestion * change best tip check * fix(rpc): Check for panics in the transaction queue (#4046) * Check for panics in the RPC transaction queue * Add missing pin! and abort in the start task * Check for transaction queue panics in tests * Fixup a new RPC test from the main branch Co-authored-by: teor <teor@riseup.net> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In PR #4015, we want to check that the transaction queue code does not panic.
Solution
Related fixes:
Review
@oxarbitrage wrote PR #4015.
This PR is based on PR #4015.
Reviewer Checklist