Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): fix syntax in some yml workflows #3957

Merged
merged 1 commit into from
Mar 24, 2022
Merged

fix(ci): fix syntax in some yml workflows #3957

merged 1 commit into from
Mar 24, 2022

Conversation

conradoplg
Copy link
Collaborator

Motivation

Two workflows have syntax errors which are preventing some jobs from running

Specifications

Designs

Solution

Fix indentation

Review

Reviewer Checklist

  • Code implements Specs and Designs
  • Tests for Expected Behaviour
  • Tests for Errors

Follow Up Work

@conradoplg conradoplg requested a review from a team as a code owner March 24, 2022 20:03
@conradoplg conradoplg requested review from gustavovalverde and removed request for a team March 24, 2022 20:03
@gustavovalverde
Copy link
Member

This is included here #3940

We can approve that one if the review is successful, or merge this one in the meanwhile.

Let me know @conradoplg

Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a low-risk fix, that's necessary to unblock CI.

So I'm ok with merging it during the high-priority NU5 updates.

mergify bot added a commit that referenced this pull request Mar 24, 2022
mergify bot added a commit that referenced this pull request Mar 24, 2022
@mergify mergify bot merged commit ed5e85f into main Mar 24, 2022
@mergify mergify bot deleted the fix-yml-syntax branch March 24, 2022 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants