Use single thread Tokio runtime for tests #2916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer versions of Tokio panic if `tokio::time::pause()` is called from a multi-thread executor, and `#[tokio::test]` defaults to a single thread runtime, so it makes sense to always use a single thread runtime in all tests.
teor2345
reviewed
Oct 21, 2021
There was a problem hiding this comment.
I think you might have skipped a few multi-threaded runtimes that don't panic:
https://github.com/ZcashFoundation/zebra/search?q=Runtime
I think that's a good idea to reduce the risk of unexpected test bugs.
But can you open a follow-up ticket to get rid of all instances of Runtime::new and similar?
|
I opened #2927 to track updating all tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is part of the update to use Tokio version 1 (#2200), but can be merged separately.
Newer versions of Tokio panic if
tokio::time::pause()is called from a multi-thread executor, so tests should be updated so that doesn't happen.Solution
Since
#[tokio::test]defaults to a single thread runtime, it makes sense to always use a single thread runtime in all tests unless there's a need for a multi-thread executor.Review
Anyone from the team can review this.
Reviewer Checklist
Follow Up Work