Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGELOG for Zebra 1.0.0-alpha.13 #2493

Merged
merged 9 commits into from
Jul 15, 2021
Merged

CHANGELOG for Zebra 1.0.0-alpha.13 #2493

merged 9 commits into from
Jul 15, 2021

Conversation

mpguerra
Copy link
Contributor

Motivation

Update CHANGELOG for Zebra 1.0.0-alpha.13 release

Review

@ZcashFoundation/zebra-team

Reviewer Checklist

  • Changes are under the correct categories
  • All significant changes are listed
  • Descriptions are non-developer friendly

Follow Up Work

Once release version update PR is merged:

  • review any new merges
  • update CHANGELOG contents if necessary
  • update release date in CHANGELOG

@mpguerra mpguerra marked this pull request as draft July 13, 2021 21:38
@mpguerra mpguerra mentioned this pull request Jul 13, 2021
6 tasks
@jvff jvff force-pushed the v1.0.0-alpha.13-changelog branch from 6eaa649 to 4e26b6e Compare July 14, 2021 19:53
@jvff jvff requested a review from teor2345 July 14, 2021 19:53
@jvff jvff self-assigned this Jul 14, 2021
CHANGELOG.md Show resolved Hide resolved
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good, just a bunch of minor suggestions.

Happy to keep anything you think is important enough to mention in the changelog.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@jvff jvff force-pushed the v1.0.0-alpha.13-changelog branch from e03ce3b to 76c1703 Compare July 14, 2021 23:38
@jvff jvff requested a review from teor2345 July 14, 2021 23:49
CHANGELOG.md Show resolved Hide resolved
teor2345
teor2345 previously approved these changes Jul 15, 2021
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, with or without the minor wording fix.

@jvff jvff marked this pull request as ready for review July 15, 2021 11:51
mpguerra and others added 8 commits July 15, 2021 11:55
I also rebased the changelog branch to make it easier to see what's
included.
Expand the PR titles a bit so that it's easier to understand what they
refer to.
They aren't really relevant to external developers.
Make it clearer what the change means to external developers.
Make it clear that this has a small impact and that ZIP-239 isn't
actually ready yet.
A single paragraph giving a broad overview of what's new.
Final step before releasing.
@jvff jvff force-pushed the v1.0.0-alpha.13-changelog branch from aae52f3 to a7a6215 Compare July 15, 2021 11:56
@jvff jvff enabled auto-merge (squash) July 15, 2021 11:58
@jvff jvff merged commit 12c60b5 into main Jul 15, 2021
@jvff jvff deleted the v1.0.0-alpha.13-changelog branch July 15, 2021 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants