Switch to an async mutex for handshake nonces #2031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
C-bug
teor2345
changed the title
teor2345
force-pushed
the
nonce-async-mutex
branch
from
7835ee3
to
bfeb131
Compare
dconnolly
reviewed
Apr 21, 2021
Comment on lines
+201
to
+203
| // It is ok to wait for the lock here, because handshakes have a short | ||
| // timeout, and the async mutex will be released when the task times | ||
| // out. |
dconnolly
approved these changes
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In the handshake code, we use a threaded mutex, which blocks all the tasks on the thread when we're waiting for a lock.
Solution
Instead, use an async mutex, which passes the thread to another task while it is waiting.
The code in this pull request has:
Review
@dconnolly can review after #2008 merges. This fix isn't urgent, but we do need to clear some of the PR backlog to avoid conflicts.
Related Issues
Closes #1995 (the error slot and address book need a threaded mutex for now)