Test the manual eq impl on sapling::ShieldedData<PerSpend> #1989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
A-rust
dconnolly
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Our initial implementation of
eqonsapling::ShieldedDatawas missing some fields. These tests check that we are comparing equality for all the fields. And they make sure that swapping the first spend and output still compares equal.Solution
ShieldedData<PerSpend>compares equalShieldedData<PerSpend>compares equalThe code in this pull request has:
Review
@oxarbitrage can review this PR. It blocks testing #1829.
Related Issues
Extra tests for #1946.
Follow Up Work
Implement and test #1829.