Enable joinsplit and spend auth sighash verification #1940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
But keep ignoring those errors until we fix binding sigs in ZcashFoundation#1939
teor2345
added
C-bug
teor2345
commented
Mar 25, 2021
|
I've marked this PR as draft until a full sync passes on mainnet and testnet. Feel free to review it, I just don't want to merge until I we're sure it works. |
teor2345
commented
Mar 25, 2021
|
3 mainnet instances synced to tip, 3 testnet instances are lagging by about 130 blocks. That's now #1941, which could be caused by network code hangs or peer issues (#1905), or the small number of peers on testnet (#704). We've had this bug before, but I haven't seen it happen on mainnet since the late 2020 / early 2021 network fixes. So I don't think it's a blocking bug. (And it's unlikely to be related to these changes anyway.) |
dconnolly
reviewed
Mar 25, 2021
dconnolly
previously approved these changes
Mar 25, 2021
dconnolly
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In #1377, we thought our sighash implementation was broken. But investigation showed that it was actually the binding signature implementation.
Solution
The code in this pull request has:
Review
This is a routine review, @dconnolly just modified this code.
Related Issues
Closes #1377
Follow Up Work
#1939 Fix binding signature errors
#1944 Use Ed25519 async batch verification