Closed
Description
openedon Mar 1, 2021
Is your feature request related to a problem? Please describe.
In #1824, we added a v5_strategy
for transaction proptests. In #1823, we add a NU5
network upgrade.
Once those PRs merge, we need to use v5_strategy
in Arbitrary for Transaction
.
Describe the solution you'd like
- Wait until Add initial support for NU5 to zebra #1823 and Add transaction version 5 #1824 have merged
- Use
v4_strategy
orv5_strategy
when the network upgrade isNU5
(both are valid) - Move the transaction version check in
transaction::Verifier::call
into a newTransaction::is_valid_for_network_upgrade
- this might be useful in the
Arbitrary
impl, or the proptests
- this might be useful in the
- Design: work out how to run
NU5
proptests when it doesn't have an activation height- currently, the code is unreachable, because
LedgerState
only containsnetwork
andheight
- currently, the code is unreachable, because
Describe alternatives you've considered
Design alternatives:
- add an optional
network_upgrade_override
toLedgerState
- pass
network_upgrade_override
as an additional argument to theArbitrary
impl - add a
network_upgrade
method toLedgerState
, and use it for allArbitrary
impls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment