apply code review suggestions

Co-authored-by: teor <teor@riseup.net>
ZcashFoundation · Nov 15, 2023 · 95ed525 · 95ed525
1 parent 072f11a
commit 95ed525
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/zebra-scan/src/config.rs b/zebra-scan/src/config.rs
@@ -3,7 +3,7 @@
 use indexmap::IndexMap;
 use serde::{Deserialize, Serialize};
 
-#[derive(Clone, Debug, Deserialize, Serialize)]
+#[derive(Clone, Debug, Eq, PartialEq, Deserialize, Serialize)]
 #[serde(deny_unknown_fields, default)]
 /// Configuration for scanning.
 pub struct Config {

diff --git a/zebrad/Cargo.toml b/zebrad/Cargo.toml
@@ -68,8 +68,8 @@ getblocktemplate-rpcs = [
     "zebra-chain/getblocktemplate-rpcs",
 ]
 
-# Experimental zebra-scan indexing
-zebra-scan = []
+# Experimental shielded blockchain scanning
+shielded-scan = ["zebra-scan"]
 
 # Experimental elasticsearch indexing
 elasticsearch = [
@@ -154,7 +154,9 @@ zebra-network = { path = "../zebra-network", version = "1.0.0-beta.31" }
 zebra-node-services = { path = "../zebra-node-services", version = "1.0.0-beta.31" }
 zebra-rpc = { path = "../zebra-rpc", version = "1.0.0-beta.31" }
 zebra-state = { path = "../zebra-state", version = "1.0.0-beta.31" }
-zebra-scan = { path = "../zebra-scan", version = "0.1.0-alpha.0" }
+
+# Experimental shielded-scan feature
+zebra-scan = { path = "../zebra-scan", version = "0.1.0-alpha.0", optional = true }
 
 # Required for crates.io publishing, but it's only used in tests
 zebra-utils = { path = "../zebra-utils", version = "1.0.0-beta.31", optional = true }

diff --git a/zebrad/src/config.rs b/zebrad/src/config.rs
@@ -46,5 +46,5 @@ pub struct ZebradConfig {
 
     #[cfg(feature = "zebra-scan")]
     /// Scanner configuration
-    pub scan: zebra_scan::config::Config,
+    pub shielded_scan: zebra_scan::config::Config,
 }