Skip to content

Commit

Permalink
The destination definition was already available from the connection …
Browse files Browse the repository at this point in the history
…form service, no need to make the call again. (airbytehq#21207)
  • Loading branch information
krishnaglick authored Jan 18, 2023
1 parent 1d202d1 commit 747d15f
Showing 1 changed file with 4 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import { useConnectionEditService } from "hooks/services/ConnectionEdit/Connecti
import { useConnectionFormService } from "hooks/services/ConnectionForm/ConnectionFormService";
import { FeatureItem, useFeature } from "hooks/services/Feature";
import { useCurrentWorkspace } from "hooks/services/useWorkspace";
import { useDestinationDefinition } from "services/connector/DestinationDefinitionService";
import { FormikOnSubmit } from "types/formik";

import styles from "./ConnectionTransformationPage.module.scss";
Expand All @@ -26,14 +25,13 @@ import { NormalizationCard } from "./NormalizationCard";

export const ConnectionTransformationPage: React.FC = () => {
const { connection, updateConnection } = useConnectionEditService();
const { mode } = useConnectionFormService();
const definition = useDestinationDefinition(connection.destination.destinationDefinitionId);
const { mode, destDefinition } = useConnectionFormService();
const workspace = useCurrentWorkspace();

useTrackPage(PageTrackingCodes.CONNECTIONS_ITEM_TRANSFORMATION);
const supportsNormalization = definition.normalizationConfig.supported;
const supportsDbt = useFeature(FeatureItem.AllowCustomDBT) && definition.supportsDbt;
const supportsCloudDbtIntegration = useFeature(FeatureItem.AllowDBTCloudIntegration) && definition.supportsDbt;
const supportsNormalization = destDefinition.normalizationConfig.supported;
const supportsDbt = useFeature(FeatureItem.AllowCustomDBT) && destDefinition.supportsDbt;
const supportsCloudDbtIntegration = useFeature(FeatureItem.AllowDBTCloudIntegration) && destDefinition.supportsDbt;
const noSupportedTransformations = !supportsNormalization && !supportsDbt && !supportsCloudDbtIntegration;

const onSubmit: FormikOnSubmit<{ transformations?: OperationRead[]; normalization?: NormalizationType }> = async (
Expand Down

0 comments on commit 747d15f

Please sign in to comment.