refactoring

src/Parser.php

@@ -32,32 +32,33 @@ public function parse()
         $xmlReader->xml($this->xml);
         $timestamp = $this->getStartTimestamp($xmlReader);
 
-        $item = [];
+        $trackpoint = new Trackpoint();
         while ($xmlReader->read()) {
             if ($xmlReader->nodeType == XMLReader::ELEMENT) {
                 switch ($xmlReader->name) {
                     case 'LatitudeDegrees':
                         $node = $xmlReader->expand();
-                        $item['latitude'] = $node->nodeValue;
+                        $trackpoint->latitude = $node->nodeValue;
                         break;
                     case 'LongitudeDegrees':
                         $node = $xmlReader->expand();
-                        $item['longitude'] = $node->nodeValue;
+                        $trackpoint->longitude = $node->nodeValue;
                         break;
                     case 'AltitudeMeters':
                         $node = $xmlReader->expand();
-                        $item['altitude'] = $node->nodeValue;
+                        $trackpoint->altitude = $node->nodeValue;
                         break;
                     case 'Time':
                         $node = $xmlReader->expand();
-                        $item['timestamp'] = strtotime($node->nodeValue) - $timestamp;
+                        $trackpoint->timestamp = strtotime($node->nodeValue) - $timestamp;
                         break;
                 }
             }
 
-            if (isset($item['latitude']) && isset($item['longitude']) && isset($item['altitude'])) {
-                $results[] = $item;
-                $item = [];
+            if ($trackpoint->isComplete()) {
+                $results[] = $trackpoint->serialize();
+                unset($trackpoint);
+                $trackpoint = new Trackpoint();
             }
         }
 

src/Trackpoint.php

@@ -0,0 +1,51 @@
+<?php
+/**
+ * Created by PhpStorm.
+ * User: Mateusz
+ * Date: 25.04.2016
+ * Time: 14:45
+ */
+
+namespace MateuszBlaszczyk\TcxToJson;
+
+
+class Trackpoint implements \Serializable
+{
+    public $latitude;
+
+    public $longitude;
+
+    public $altitude;
+
+    public $timestamp;
+
+    public function isComplete()
+    {
+        if ($this->latitude && $this->longitude && $this->altitude) {
+            return true;
+        }
+
+        return false;
+    }
+
+    public function serialize()
+    {
+        return [
+            'latitude' => $this->latitude,
+            'longitude' => $this->longitude,
+            'altitude' => $this->altitude,
+            'timestamp' => $this->timestamp,
+        ];
+    }
+
+    public function unserialize($serialized)
+    {
+        $item = new Trackpoint();
+        $item->latitude = $serialized['latitude'];
+        $item->longitude = $serialized['longitude'];
+        $item->altitude = $serialized['altitude'];
+        $item->timestamp = $serialized['timestamp'];
+
+        return $item;
+    }
+}