[feat/add-elm-format-options] #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds ability to pass in command-line options to `elm-format` (:ElmFormat)
|
Hi, thank you for contributing this! Interesting to see. I just wanted to check though as I thought that maybe the most recent versions of elm-format automatically detected the required version anyway? Based off whether there is an elm.json or an elm-package.json file? Is that not the case? Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability to pass in command-line options to
elm-format(:ElmFormat).This is useful, to set the
--elm-versionoption for0.18users, for instance. Let me know if this makes more sense to just have an explicit option likeg:elm_format_versionfor this, so it doesn't interfere with the order of operations for the temp file creation and output.