Wordpress Plugin Submission Review fixes #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In regards to the Wordpress Plugin Submission Review email:
we should be good for (1) and (2) because we run the "WordPress Coding Standards for PHPCS" via npm run lint
added screenshots @john-zaprite feel free to add more or modify see guide here https://chat.openai.com/share/9e2ecb6f-e6bd-4b5b-a853-447a71fd22cf
fixed one function prefix that was not in a namespace.
We should be good to submit the review to Wordpress, much of the heavy lifting was done when submitting to the WooCommerce store, so I suspect the code should be pretty much good.