Pull Request: CertificateThumbprint, Public Key Cert Export, and Add-SRDSCNode Update #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CertificateThumbprint Public Key Cert is exported to ProgramData Updated Add-SRDSCNode to support automatic cert enrollment
added 3 commits
June 14, 2023 17:49
Updating Version
…cate-auto-enrollment
ZanattaMichael
deleted the
20-feature-add-automatic-pull-server-certificate-auto-enrollment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am submitting this pull request to address three issues related to certificate management in our codebase. Specifically, this pull request includes updates to the
CertificateThumbprintfunction, adds support for exporting public key certificates to ProgramData, and updates theAdd-SRDSCNodefunction to support automatic certificate enrollment.Changes Made
CertificateThumbprintfunction has been updated to include additional error handling and logging capabilities. This will help ensure that any errors related to certificate management are properly identified and addressed.Add-SRDSCNodefunction has been updated to automatically enroll nodes with the appropriate certificates. This will help streamline the process of adding new nodes to the system and ensure that they are properly authenticated.How to Test
To test these changes, please run the following commands:
CertificateThumbprintfunction with various inputs to ensure that error handling and logging work as expected.Add-SRDSCNodefunction to add a new node to the system and verify that it is properly enrolled with the appropriate certificates.Additional Notes
These changes were made in response to feedback from users who have experienced issues related to certificate management in our codebase. We believe that these updates will help improve the overall functionality and reliability of our system.