-
Notifications
You must be signed in to change notification settings - Fork 69
Angular 19 support #187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Angular 19 support #187
Conversation
@Zak-C any news on this? Would be usefull 😄 |
As I stated in #186 the author seems very inactive. I checked their contributions (last contribution January 2024). So I don't think the merge will happen. @ArthurDrevot if it is okay for you I would like to merge your PR in my fork and release a new version on npmjs. I roughly read through your changes (best as possible on mobile 😅) and it looks satisfying. Are there any setup changes which I have to update in the readme? |
@ArthurDrevot I took the liberty and merged your PR into my fork. On the first glance it looked good so it will be v19.0.0, if I find any issues when I am working with it I will fix them in my fork. |
Perfect @Epsilon02 ! Sorry I didn’t really take the time to do it earlier. Great to hear everything’s working fine. Too bad we can’t retrieve the npm package name. It means we have to switch packages to use yours in a project. |
@Epsilon02 next step: should we move the project to follow the new best practices with standalone components and signals? 😜 |
@ArthurDrevot no problem. As you can see, since my last comment, I wanted to do this also earlier than I did. Yes it is sad we can't retrieve the original name but I am quite happy with the new name (except you have a better one). But the switch shouldn't be that much of a hassle.
Yes please 😄 if you create an account on codeberg (of course only when the registration server is back on again) I would add you as a collaborator if you want. (if wanted I can also try to create a mirror here on github, but this is the first time I do this, so I am not sure how well it will work and if I do some mistakes on the way) |
This PR upgrades the library from Angular 17 to Angular 19 to take advantage of the latest improvements and security fixes.
🔄 Changes made:
✅ Tests performed:
Please review this MR and let me know your feedback! 😊