This repository was archived by the owner on Jan 1, 2023. It is now read-only.
Working sample of Fabimals with Shell #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tem and FormattedString working in Fabimals; -Add tag, grid, layout properties that was needed;
-Add CollectionView and SearchHandler; -Typos fixed;
|
Wow @Blener, this looks like a lot of work! By taking a glance I am sure I won't be able to spot quickly where things will go wrong so I will just merge and publish 😄 |
|
Published as v0.38 🚀 If something doesn't work, we will definitely hear about it ;) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @Zaid-Ajaj
I've tried to implement Shell again, this time I created a new sample on top of Fabimals.
I don't have a mac right now, so it's only been tested in Android. Also I've only tested with the sample, so not all properties are tested.
Since it's a big change I'll leave the PR for you to approve.
Any fixes or changes just let me know, thank you.